Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-4668: Enable Lz4Raw & rm parquet_format_async_temp #4726

Merged
merged 12 commits into from
Apr 8, 2022
Merged

ISSUE-4668: Enable Lz4Raw & rm parquet_format_async_temp #4726

merged 12 commits into from
Apr 8, 2022

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Apr 6, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

WIP issue:

Changelog

  • Bug Fix
  • Improvement
  • Not for changelog (changelog entry is not required)

Related Issues

Fixes #4668 #4675

@vercel
Copy link

vercel bot commented Apr 6, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/2oKmcnArQM35d94RWSvADMvdrQVX
✅ Preview: https://databend-git-fork-dantengsky-fix-bump-parquet2-databend.vercel.app

@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added pr-bugfix this PR patches a bug in codebase pr-improvement labels Apr 6, 2022
@Xuanwo
Copy link
Member

Xuanwo commented Apr 6, 2022

ERROR databend_query::servers::mysql::writers::query_result_writer: OnQuery Error: Code: 1024, displayText = External format error: Compression Lz4 is not yet supported (while in processor thread 0).

@dantengsky
Copy link
Member Author

ERROR databend_query::servers::mysql::writers::query_result_writer: OnQuery Error: Code: 1024, displayText = External format error: Compression Lz4 is not yet supported (while in processor thread 0).

roger. How can it be reproduced, pls?

@dantengsky
Copy link
Member Author

ERROR databend_query::servers::mysql::writers::query_result_writer: OnQuery Error: Code: 1024, displayText = External format error: Compression Lz4 is not yet supported (while in processor thread 0).

roger. How can it be reproduced, pls?

oh , pls ignore me, I found the error log :D

@dantengsky dantengsky marked this pull request as ready for review April 7, 2022 15:35
@dantengsky dantengsky requested a review from BohuTANG as a code owner April 7, 2022 15:35
@dantengsky
Copy link
Member Author

@BohuTANG @Xuanwo please take another look

@dantengsky @Xuanwo
Update query/src/storages/fuse/meta/common.rs
755e412 
derive Copy for enum Compression

Co-authored-by: Xuanwo <github@xuanwo.io>
BohuTANG
BohuTANG approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@BohuTANG
Copy link
Member

BohuTANG commented Apr 8, 2022

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Apr 8, 2022

update

✅ Branch has been successfully updated

Hey, I reacted but my real name is @Mergifyio

@BohuTANG BohuTANG merged commit b0c7f01 into databendlabs:main Apr 8, 2022
@Xuanwo Xuanwo mentioned this pull request Apr 8, 2022
Closed
@BohuTANG BohuTANG mentioned this pull request Apr 23, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@BohuTANG BohuTANG BohuTANG approved these changes

Assignees
No one assigned
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump parquet2 to 0.10.3 & replace compression algo LZ4 with LZ4Raw
4 participants
@dantengsky @Xuanwo @BohuTANG @databend-bot